Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][gcs] - Simplified state checkpoint calculation #40937

Merged
merged 13 commits into from
Oct 3, 2024
Merged

[filebeat][gcs] - Simplified state checkpoint calculation #40937

merged 13 commits into from
Oct 3, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Enhancement

Proposed commit message

  • WHAT: Simplified state checkpoint calculation
  • WHY: The existing state checkpoint calculation logic was convoluted and depended on unreliable flag logic, then it has been simplified so that if errors occur they are become simpler to debug.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner September 21, 2024 06:23
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 21, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 21, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label labels Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@ShourieG ShourieG added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label input:GCS labels Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
efd6
efd6 reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments to the azureblobstorage change.

@ShourieG
Copy link
Contributor Author

@efd6, updated with similar changes as the abs input.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 30, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcs/simplify_state upstream/gcs/simplify_state
git merge upstream/main
git push upstream gcs/simplify_state

@ShourieG ShourieG merged commit 488c445 into elastic:main Oct 3, 2024
22 checks passed
@ShourieG ShourieG deleted the gcs/simplify_state branch October 3, 2024 09:21
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
@ShourieG @mergify
[filebeat][gcs] - Simplified state checkpoint calculation (#40937)
fc90476 
* Simplified state checkpoint calculation. The existing state checkpoint calculation logic was convoluted and depended on unreliable flag logic, then it has been simplified so that if errors occur they are become simpler to debug.

(cherry picked from commit 488c445)
@mergify mergify bot mentioned this pull request Oct 3, 2024
Merged
6 tasks
ShourieG pushed a commit that referenced this pull request Oct 8, 2024
@mergify
[filebeat][gcs] - Simplified state checkpoint calculation (#40937) (#…
903b62e 
…41094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Filebeat Filebeat input:GCS Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify GCS input state calculation logic
3 participants
@ShourieG @elasticmachine @efd6